This repository was archived by the owner on Nov 19, 2023. It is now read-only.
Update to latest prql-compiler #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snth
reviewed
Jan 25, 2023
| if query.starts_with("prql ") { | ||
| // replace the table placeholders again | ||
| for (alias, source) in sources.iter() { | ||
| debug!("alias = {alias:?}; source = {source:?}"); |
Member
There was a problem hiding this comment.
I need to look over these changes more and try them out. I know what I had was quite hacky but I think there was a reason for it.
Member
Author
There was a problem hiding this comment.
If I try to summarize, you had something like this:
prql_source
.split_by_lines()
.insert(
1, "table source_name = (from a_name = a_key)"
)
.join('\n')
.compile_prql()
.replace('a_key', "read_csv('source_file.csv')")
I've changed it to:
let pl_stmts = parse(prql_source)
pl_stmts.insert(1, parse("let source_name = s'''read_csv('source_file.csv')'''"))
compile(pl_stmts)
This reverts commit ffac2e3.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.