[GUI] Add differentiation for Shielded Memos #2865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzbawls
reviewed
May 16, 2023
Collaborator
Fuzzbawls
left a comment
There was a problem hiding this comment.
First look at code only; looks overall good. One issue with css assignment though, and I do think that the changes here are narrow-focused enough to where the commits can be squashed down into a single commit.
I'm also not completely sold on the particular icon being used to identify memo-containing transactions (my first instinct when I see the "down arrow" is that there is a download). That, however, can be left for further discussion and refinement in a later PR, if need be.
Add new icon for memo and add to qrc/makefile Remove CSS from RecvWithShieldedAddressMemo Add css Adjust CSS
8db40b1 to
2543f6b
Compare
Fuzzbawls
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new TransactionRecord
RecvWithShieldedAddressMemoand icon/image for the transaction.With the conversation in Issue #2786 , there is something we can do and that changes the icon and checking for memo to not be empty.
Color for blue is not in this PR, but to make it easier to see is in the picture.
I have also spoken with a few, where they feel more may still be warranted to make this stand out so open for options/feedback for us to update this more.
Closes #2786