Move GetCredit CTransaction to CWalletTx to be able to decrypt the sapling note if needed.

furszy · furszy · commit b47e783602e8 · 2020-11-04T20:35:40.000-03:00
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -4450,7 +4450,7 @@ CAmount CWallet::GetDebit(const CTransaction& tx, const isminefilter& filter) co
     return nDebit;
 }
 
-CAmount CWallet::GetCredit(const CTransaction& tx, const isminefilter& filter) const
+CAmount CWallet::GetCredit(const CWalletTx& tx, const isminefilter& filter) const
 {
     CAmount nCredit = 0;
     for (unsigned int i = 0; i < tx.vout.size(); i++) {
diff --git a/src/wallet/wallet.h b/src/wallet/wallet.h
@@ -689,7 +689,7 @@ class CWallet : public CCryptoKeyStore, public CValidationInterface
     /** should probably be renamed to IsRelevantToMe */
     bool IsFromMe(const CTransaction& tx) const;
     CAmount GetDebit(const CTransaction& tx, const isminefilter& filter) const;
-    CAmount GetCredit(const CTransaction& tx, const isminefilter& filter) const;
+    CAmount GetCredit(const CWalletTx& tx, const isminefilter& filter) const;
     CAmount GetChange(const CTransaction& tx) const;
 
     //! Sapling merkle tree update

Original file line number	Diff line number	Diff line change
`@@ -4450,7 +4450,7 @@ CAmount CWallet::GetDebit(const CTransaction& tx, const isminefilter& filter) co`
`4450`	`4450`	`return nDebit;`
`4451`	`4451`	`}`
`4452`	`4452`
`4453`		`-CAmount CWallet::GetCredit(const CTransaction& tx, const isminefilter& filter) const`
	`4453`	`+CAmount CWallet::GetCredit(const CWalletTx& tx, const isminefilter& filter) const`
`4454`	`4454`	`{`
`4455`	`4455`	`CAmount nCredit = 0;`
`4456`	`4456`	`for (unsigned int i = 0; i < tx.vout.size(); i++) {`