Drop support for PHP 5.3 and PHPCS < 2.6.0#956
Merged
Conversation
ec3d85b to
1d4d979
Compare
wimg
reviewed
Dec 27, 2019
This: * Updates the minimum requirements in `composer.json`, the `README` and the `CONTRIBUTING` docs. * Updates the Travis script to no longer test against PHP 5.3, nor PHPCS < 2.6.0. * Updates the `LowPHPCS` and `LowPHP` sniffs to reflect the new minimum and recommended PHP and PHPCS versions. * Updates the PHPCS ruleset to now longer check the code of PHPCompatibility for cross-version compatibility with PHP 5.3.
The `T_POW` token was back-filled in PHPCS 2.4.0.
The `T_ANON_CLASS` token was added in PHPCS 2.4.0.
The `T_RETURN_TYPE` token was added in PHPCS 2.4.0 and deprecated in PHPCS 3.3.0. It is expected to be removed in PHPCS 4.0.0.
We can now simplify the sniff to just check for the `T_ANON_CLASS` token.
Includes minor efficiency fix.
The `T_OPEN_USE_GROUP` and `T_CLOSE_USE_GROUP` tokens were introduced in PHPCS 2.6.0, so no more need for work arounds.
… only) Remove redundant `@requires` tags.
….6.0 (tests only)
…CS < 2.6.0 (tests only)
… 2.6.0 (tests only)
…< 2.6.0 (tests only)
…PHPCS < 2.6.0 (tests only)
1d4d979 to
93553c5
Compare
wimg
approved these changes
Feb 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This:
composer.json, theREADMEand theCONTRIBUTINGdocs.LowPHPCSandLowPHPsniffs to reflect the new minimum and recommended PHP and PHPCS versions.Includes removing any and all work-arounds for supporting PHPCS < 2.6.0 and PHP < 5.4 which I could find in the codebase.
See the individual commits for full details.
Closes #835