Skip to content

PHP 7.0/7.4: handle removed & re-introduced tokenizer constant(s)#882

Merged
wimg merged 2 commits intomasterfrom
feature/removed-new-tokenizer-constants
Aug 28, 2019
Merged

PHP 7.0/7.4: handle removed & re-introduced tokenizer constant(s)#882
wimg merged 2 commits intomasterfrom
feature/removed-new-tokenizer-constants

Conversation

@jrfnl
Copy link
Copy Markdown
Member

@jrfnl jrfnl commented Aug 26, 2019

PHP 7.0/RemovedConstants: handle removed tokenizer constants

Ref:

PHP 7.4/NewConstants: handle new T_BAD_CHARACTER token

Tokenizer:
token_get_all() will now emit a T_BAD_CHARACTER token for unexpected
characters instead of leaving behind holes in the token stream.

Refs:

Related to #808

jrfnl added 2 commits August 26, 2019 21:02
> Tokenizer:
>  token_get_all() will now emit a T_BAD_CHARACTER token for unexpected
characters instead of leaving behind holes in the token stream.

Refs:
* https://github.com/php/php-src/blob/3775d47eee38f3b34f800a0b23f840ec7a94e4c7/UPGRADING#L152-L154
* php/php-src@9ad094e
@jrfnl jrfnl added Type: enhancement PR: quick merge PR only contains relatively simple changes PR: ready for review labels Aug 26, 2019
@jrfnl jrfnl added this to the 9.3.0 milestone Aug 26, 2019
@jrfnl jrfnl requested a review from wimg August 26, 2019 19:23
@jrfnl jrfnl changed the title PHP 7.0/7.4: handle removed & re-introduced tokenizes constant(s) PHP 7.0/7.4: handle removed & re-introduced tokenizer constant(s) Aug 26, 2019
@wimg wimg merged commit ab8b218 into master Aug 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/removed-new-tokenizer-constants branch August 28, 2019 14:06
@jrfnl jrfnl removed PR: ready for review PR: quick merge PR only contains relatively simple changes labels Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants