Conversation
This was referenced Jul 29, 2019
e678aed to
fe7d4c1
Compare
… using curly braces What with PHP 7.4 deprecating the array dereferencing syntax with curly braces, I've been doing some research on where this was supported up to now. Turns out that, as of PHP 7.0, function array dereferencing using curly braces has been supported. See: https://3v4l.org/a1TW6 While the PHP 7.0 changelog makes no note of this, the change was probably part of the PHP 7.0 [Uniform Variable Syntax](https://wiki.php.net/rfc/uniform_variable_syntax) changes. This PR adjusts the `PHPCompatibility.Syntax.NewFunctionArrayDereferencing` sniff to: * Also recognize curly braces.; * Throw an error for each access detected, i.e. `$foo->bar()[1][0]` would previously throw just the one error, now it will throw two. * Throw the error on the token used for the access, not on the closing parenthesis of the function call. * Prevent false positives on functions declared by reference. Includes unit tests. The actual logic has been split off to a separate `isFunctionArrayDereferencing()` method to allow it to be re-used for the upcoming sniff which will detect the PHP 7.4 curly brace deprecation.
fe7d4c1 to
2012bb7
Compare
wimg
approved these changes
Aug 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What with PHP 7.4 deprecating the array dereferencing syntax with curly braces, I've been doing some research on where this was supported up to now.
Turns out that, as of PHP 7.0, function array dereferencing using curly braces has been supported.
See: https://3v4l.org/a1TW6
While the PHP 7.0 changelog makes no note of this, the change was probably part of the PHP 7.0 Uniform Variable Syntax changes.
This PR adjusts the
PHPCompatibility.Syntax.NewFunctionArrayDereferencingsniff to:$foo->bar()[1][0]would previously throw just the one error, now it will throw two.Includes unit tests.
The actual logic has been split off to a separate
isFunctionArrayDereferencing()method to allow it to be re-used for the upcoming sniff which will detect the PHP 7.4 curly brace deprecation.