Sniff: Add new isShortList() utility function#635
Merged
Conversation
e54ac8b to
c7ab733
Compare
c7ab733 to
d9adecd
Compare
... to determine whether a short array is a short list syntax. Includes unit tests.
wimg
approved these changes
Jun 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... to determine whether a short array is in actual fact a short list syntax.
The utility method also accounts for two different PHPCS tokenizer bugs, one which affects PHPCS 1.5.x and the other which affects PHPCS 2.0 - 2.7.x.
There may be more tokenizer bugs we need to account for, but these are the ones I've found so far.
Includes dedicated unit tests.
This new utility function is needed for
threefive new sniffs + one existing sniff, which all deal with, or at least have to be able to recognize, shortlistconstructs.