Skip to content

PHP 7.2: Add sniffing for usage of the T_COALESCE_EQUAL token#340

Merged
wimg merged 1 commit intoPHPCompatibility:masterfrom
jrfnl:feature/fix-null-coalesce-unit-test
Feb 17, 2017
Merged

PHP 7.2: Add sniffing for usage of the T_COALESCE_EQUAL token#340
wimg merged 1 commit intoPHPCompatibility:masterfrom
jrfnl:feature/fix-null-coalesce-unit-test

Conversation

@jrfnl
Copy link
Copy Markdown
Member

@jrfnl jrfnl commented Feb 17, 2017

The T_COALESCE_EQUAL token is expected to be introduced in PHP 7.2.
Ref: https://wiki.php.net/rfc/null_coalesce_equal_operator

This includes a fix for a previously incorrect unit test which was already testing for this construct but incorrectly identifying it as T_COALESCE.

Note: the token has NOT been merged into PHP itself yet, but has been added to PHPCS already, so implementation details and version number may still change.

The `T_COALESCE_EQUAL` token is expected to be introduced in PHP 7.2.
Ref: https://wiki.php.net/rfc/null_coalesce_equal_operator

This includes a fix for a previously incorrect unit test which was _already_ testing for this construct but incorrectly identifying it as `T_COALESCE`.
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 17, 2017

Coverage Status

Coverage decreased (-0.1%) to 96.914% when pulling 4bc6506 on jrfnl:feature/fix-null-coalesce-unit-test into 4015618 on wimg:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 96.914% when pulling 4bc6506 on jrfnl:feature/fix-null-coalesce-unit-test into 4015618 on wimg:master.

@wimg wimg merged commit db947ce into PHPCompatibility:master Feb 17, 2017
@jrfnl jrfnl deleted the feature/fix-null-coalesce-unit-test branch February 17, 2017 22:08
@jrfnl jrfnl added this to the 7.1.2 milestone May 2, 2017
@jrfnl
Copy link
Copy Markdown
Member Author

jrfnl commented Jun 1, 2019

Related #808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants