Allow for multiple variables made global in ForbiddenGlobalVariableVariableSniff#316
Merged
wimg merged 1 commit intoPHPCompatibility:masterfrom Jan 3, 2017
Conversation
b320a86 to
36a4fca
Compare
…riableSniff The ForbiddenGlobalVariableVariableSniff would currently only detect variable variables in a global statement if it was the first variable of the statement. It basically didn't take multi-variable global statements into account. Includes additional unit tests. Includes reworking the test class to use data providers as there are now more test cases.
36a4fca to
aaa2231
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ForbiddenGlobalVariableVariableSniffwould currently only detect variable variables in aglobalstatement if it was the first variable of the statement.It basically didn't take multi-variable
globalstatements into account.Includes additional unit tests.
Includes reworking the test class to use data providers as there are now more test cases.