PHP 7.4 | Syntax/NewArrayUnpacking: add XML documentation#2021
Merged
jrfnl merged 3 commits intoPHPCompatibility:developfrom Dec 14, 2025
Merged
PHP 7.4 | Syntax/NewArrayUnpacking: add XML documentation#2021jrfnl merged 3 commits intoPHPCompatibility:developfrom
jrfnl merged 3 commits intoPHPCompatibility:developfrom
Conversation
jrfnl
reviewed
Dec 13, 2025
Member
There was a problem hiding this comment.
@okkun-sh Thanks for continuing your work on the documentation!
Just one question - would it make sense to maybe show some more alternatives on the "cross-version compatible" side of the comparison ?
For example:
$a = [2, 3];
$c = [0, 1, 4, 5];
array_splice($c, 2, 0, $a);... is also equivalent to $b = [0, 1, ...$a, 4, 5]; (with $c being changed by reference in the array_splice())
Contributor
Author
@jrfnl I didn't find a better example, so I will use the array_splice() example you suggested. |
Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
okkun-sh
commented
Dec 14, 2025
Contributor
Author
|
@jrfnl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add XML documentation for the Syntax/NewArrayUnpacking sniff.
This contributes to #1285.
Thanks!