PHP 7.3 | Syntax/NewFunctionCallTrailingComma: add XML documentation#2018
Merged
jrfnl merged 2 commits intoPHPCompatibility:developfrom Dec 8, 2025
Merged
Conversation
jrfnl
reviewed
Dec 5, 2025
Member
jrfnl
left a comment
There was a problem hiding this comment.
@okkun-sh Thanks for the PR, Happy to merge this as-is.
I just have one question for which I'm curious what your reasoning was:
The sniff addresses two different, but closely related changes in PHP, one from PHP 7.3, one from PHP 8.4.
Have you considered having two <standard> blocks, each with their own code comparison, one for each change in PHP ?
The second change could then possibly be placed more in the context in which it was made (exit as a function call RFC) ?
Contributor
Author
Contributor
Author
|
@jrfnl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add XML documentation for the Syntax/NewFunctionCallTrailingComma sniff.
This contributes to #1285.
Thanks in advance!