Conversation
... to benefit from a tokenizer bug fix where a PHP close tag would not be recognized as a statement closer for a `case`/`default` statement. Includes updating references to the PHPCS version whenever relevant throughout the codebase. Ref: * https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/4.0.1
…gCaseWithSemicolon` sniff (RFC) > . Terminating case statements with a semicolon instead of a colon has > been deprecated. > RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_semicolon_after_case_in_switch_statement This commit adds a new sniff to detect and auto-fix this issue. Includes tests. Includes fixer (manually tested as the test framework does not allow for testing this currently). Includes documentation. Refs: * https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_semicolon_after_case_in_switch_statement * https://github.com/php/php-src/blob/1570ce9f551f7dff3f51690e5c03b0f5ae0e159f/UPGRADING#L370-L372 * php/php-src 19215 * php/php-src@5f8d648 * https://externals.io/message/128839 * php/php-src 20172 * php/php-src@c03215b Related to 1849
70 tasks
wimg
approved these changes
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composer: raise the minimum supported PHPCS to 4.0.1
... to benefit from a tokenizer bug fix where a PHP close tag would not be recognized as a statement closer for a
case/defaultstatement.Includes updating references to the PHPCS version whenever relevant throughout the codebase.
Ref:
PHP 8.5 | ✨ New
PHPCompatibility.ControlStructures.RemovedTerminatingCaseWithSemicolonsniff (RFC)This commit adds a new sniff to detect and auto-fix this issue.
Includes tests.
Includes fixer (manually tested as the test framework does not allow for testing this currently).
Includes documentation.
Refs:
Related to #1849