[xml doc] NewShortArray#1997
Merged
jrfnl merged 2 commits intoPHPCompatibility:developfrom Nov 22, 2025
Merged
Conversation
jrfnl
approved these changes
Nov 19, 2025
Member
jrfnl
left a comment
There was a problem hiding this comment.
Hi @okkun-sh Thank you for this PR and your willingness to contribute!
The PR is looking good and complies with all doc requirements. Well done.
I left two very small nitpicky comments inline as suggestions to make the code highlighting for this issue clearer.
Let me know what you think. If you like I can fix those up on merge.
Member
|
P.S.: don't worry about the CS check failing - that is a known issue and PR #1983 will take care of that ;-) |
Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
Contributor
Author
|
@jrfnl |
Member
|
Thanks for contributing @okkun-sh ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add XML documentation for the NewShortArray sniff.
I picked this from #1285 as something I could contribute.
This is my first contribution to this project. Feedback is welcome!