PHP 8.5: Deprecate NumberFormatter::TYPE_CURRENCY #1975
+359
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scaffolding is there to allow for easily adding soft deprecations and removals later on, similar to how RemovedMagicMethods does it.
Getting the content of tokens is easier to reason about because the sprintf gives a hint about the expected string format we later compare.
35 tasks
- Pass the pointer of the constant name to addMessage() instead of the double colon. This was needed to satisfy the multiline test case. - Comments on test cases are now more detailed to make it easier to reason about and maintain the test.
- Capture a variety of syntaxes where the target class and constant names are present, but it's not the _syntax_ we want.
Contributor
Author
|
@jrfnl Did we ever solve the question of documenting sniffs that cover different items, like RemovedFunctions? It makes no sense to put them all in the same *Standard.xml file. What should I do about the docs for this PR? Other than that, it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of this effort: #1849
Adding a sniff for removed/deprecated class constants
NumberFormatter::TYPE_CURRENCY. This is different from bare constants likeMCRYPT_MODE_CFB.Implemented in a similar fashion to
RemovedMagicMethods.Class constant NumberFormatter::TYPE_CURRENCY is deprecated since PHP 8.3..SoftDeprecated,DeprecatedandRemoved.