PHP 8.5 | RemovedIniDirectives: detect use of intl.error_level (RFC) #1965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> - Intl: > . The intl.error_level INI setting has been deprecated. > Errors should either be checked manually or exceptions should be enabled > by using the intl.use_exceptions INI setting. > RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_intlerror_level_ini_setting This commit accounts for the deprecation of the ini setting. In the RFC (and the implementation), the deprecation is conditional on the value: > we propose deprecating this INI setting, meaning setting it to any value different than `0` will raise an `E_DEPRECATED` diagnostic. However, for the purpose of PHPCompatibility, I believe checking the value for a call to `ini_set()` is a little over the top. If anyone would report false positives because of this, we can always consider adding such a check later. Refs: * https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_intlerror_level_ini_setting * https://github.com/php/php-src/blob/1570ce9f551f7dff3f51690e5c03b0f5ae0e159f/UPGRADING#L446-L450 * php/php-src 19430 * php/php-src@69f67f9 Related to 1849
wimg
approved these changes
Oct 27, 2025
70 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit accounts for the deprecation of the ini setting.
In the RFC (and the implementation), the deprecation is conditional on the value:
However, for the purpose of PHPCompatibility, I believe checking the value for a call to
ini_set()is a little over the top. If anyone would report false positives because of this, we can always consider adding such a check later.Refs:
Related to #1849