PHP 8.5 | NewFunctionParameters: detect use of grapheme_*() $locale (RFC) #1947
+64
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RFC) > . grapheme_strpos(), grapheme_stripos(), grapheme_strrpos(), > grapheme_strripos(), grapheme_strstr(), grapheme_stristr() and > grapheme_levenshtein() functions add $locale parameter. > RFC: https://wiki.php.net/rfc/grapheme_add_locale_for_case_insensitive This commit accounts for detecting the new parameters. Note: the changelog entry is missing one function and has one too many. See PR php/php-src 20239 Refs: * https://wiki.php.net/rfc/grapheme_add_locale_for_case_insensitive * https://github.com/php/php-src/blob/c2523ed581d622df802dfe3878c01de89828bf21/UPGRADING#L608-L611 * php/php-src 18792 * php/php-src@ad75c26 * https://www.php.net/manual/en/ref.intl.grapheme.php Related to 1849
70 tasks
wimg
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit accounts for detecting the new parameters.
Note: the changelog entry is missing one function and has one too many. See PR php/php-src#20239
Refs:
Related to #1849