Skip to content

Generators/NewYieldFromComment: simplify the code#1812

Merged
wimg merged 1 commit intodevelopfrom
feature/newyieldfromcomment-simplify
Aug 6, 2025
Merged

Generators/NewYieldFromComment: simplify the code#1812
wimg merged 1 commit intodevelopfrom
feature/newyieldfromcomment-simplify

Conversation

@jrfnl
Copy link
Copy Markdown
Member

@jrfnl jrfnl commented Jul 6, 2025

⚠️ This PR needs for PR #1806 to be merged first to allow CI to pass. ⚠️ (PR #1806 has been merged)


Follow up on #1792

Now support for PHPCS < 3.13.0 has been dropped, some cross-version compatibility code can be dropped from this sniff.

@jrfnl jrfnl added this to the 10.0.0 milestone Jul 6, 2025
@jrfnl jrfnl added Type: chores/QA PR: quick merge PR only contains relatively simple changes PR: ready for review labels Jul 6, 2025
@jrfnl jrfnl requested a review from wimg July 6, 2025 01:54
Base automatically changed from feature/composer-update-for-phpcsutils-1.1.0 to develop July 6, 2025 13:28
Follow up on 1792

Now support for PHPCS < 3.13.0 has been dropped, some cross-version compatibility code can be dropped from this sniff.
@jrfnl jrfnl force-pushed the feature/newyieldfromcomment-simplify branch from 96a9fcb to 3347beb Compare July 6, 2025 13:41
@jrfnl
Copy link
Copy Markdown
Member Author

jrfnl commented Jul 6, 2025

Rebased without changes after the merge of #1806 and marked as "ready for review".

@jrfnl jrfnl marked this pull request as ready for review July 6, 2025 13:41
@wimg wimg merged commit ec9a1a9 into develop Aug 6, 2025
46 checks passed
@wimg wimg deleted the feature/newyieldfromcomment-simplify branch August 6, 2025 19:20
@github-actions github-actions bot removed PR: quick merge PR only contains relatively simple changes PR: ready for review labels Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants