PHP 8.4 | Detect use of asymmetric visibility #1809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ee6356 to
f569d2c
Compare
58 tasks
Base automatically changed from
feature/composer-update-for-phpcsutils-1.1.0
to
develop
July 6, 2025 13:28
> . Implemented asymmetric property visibility. > RFC: https://wiki.php.net/rfc/asymmetric-visibility-v2 This commit adds detection of the use of asymmetric visibility via the dedicated tokens to the `NewKeywords` sniff. Includes tests. Includes adding some additional RFC links previously missed. Refs: * https://wiki.php.net/rfc/asymmetric-visibility-v2 * https://github.com/php/php-src/blob/2aeefb13bec49dcf59e644d85f5e7a04787bec55/UPGRADING#L296-L297 * php/php-src 15063 * php/php-src@8df557a Related to 1731
…stants > . Implemented asymmetric property visibility. > RFC: https://wiki.php.net/rfc/asymmetric-visibility-v2 This commit adds detection of the use of the asymmetric visibility tokens to the `NewConstants` sniff. Includes tests. Refs: * https://wiki.php.net/rfc/asymmetric-visibility-v2 * https://github.com/php/php-src/blob/2aeefb13bec49dcf59e644d85f5e7a04787bec55/UPGRADING#L296-L297 * php/php-src 15063 * php/php-src@8df557a Related to 1731
f569d2c to
58f8c26
Compare
Member
Author
|
Rebased without changes after the merge of #1806 and marked as "ready for review". |
wimg
approved these changes
Jul 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚠️ This PR needs for PR #1806 to be merged first. It relies on functionality supported since PHPCS 3.13.0. ⚠️ PHP 8.4 | NewKeywords: detect use of asymmetric visibility
This commit adds detection of the use of asymmetric visibility via the dedicated tokens to the
NewKeywordssniff.Includes tests.
Includes adding some additional RFC links previously missed.
Refs:
Related to #1731
PHP 8.4 | NewConstants: detect use of asymmetric visibility token constants
This commit adds detection of the use of the asymmetric visibility tokens to the
NewConstantssniff.Includes tests.
Refs:
Related to #1731