Conversation
…llFalse sniff (RFC) > . Passing null or false to dba_key_split() is deprecated. > RFC: https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_passing_null_and_false_to_dba_key_split This commit introduces a new sniff to detect and flag this. The sniff checks for calls to the typical `dba_firstkey()` and `dba_nextkey()` functions being passed straight into a call to `dba_key_split()`. Both `dba_firstkey()` and `dba_nextkey()` can return `false`, so their return value needs to be checked before passing it on to `dba_key_split()`. As a fall-back, though much less likely to match real-world code, the sniff also checks for hard-coded `false` or `null` values being passed to a call to `dba_key_split()`. When the key is passed as a variable, the sniff will stay silent (undetermined). Includes tests. Includes documentation. Refs: * https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_passing_null_and_false_to_dba_key_split * https://github.com/php/php-src/blob/634708a14f9546cc81bc5f9bf269ec0c46743a0f/UPGRADING#L423-L425 * php/php-src 15297 * php/php-src@bb2836e Related to 1731
58 tasks
wimg
approved these changes
Sep 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new sniff to detect and flag this.
The sniff checks for calls to the typical
dba_firstkey()anddba_nextkey()functions being passed straight into a call todba_key_split(). Bothdba_firstkey()anddba_nextkey()can returnfalse, so their return value needs to be checked before passing it on todba_key_split().As a fall-back, though much less likely to match real-world code, the sniff also checks for hard-coded
falseornullvalues being passed to a call todba_key_split().When the key is passed as a variable, the sniff will stay silent (undetermined).
Includes tests.
Includes documentation.
Refs:
Related to #1731