PHP 8.4 | OptionalToRequiredFunctionParameters: account for deprecation of overloaded pg_*() signatures (RFC) #1736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of overloaded pg_*() signatures (RFC) > - PgSQL: > . Calling pg_fetch_result() with 2 arguments is deprecated. Use the > 3-parameter signature with a null $row parameter instead. > . Calling pg_field_prtlen() with 2 arguments is deprecated. Use the > 3-parameter signature with a null $row parameter instead. > . Calling pg_field_is_null() with 2 arguments is deprecated. Use the > 3-parameter signature with a null $row parameter instead. Note: when named parameters are used, the sniff will use the correct parameter name in the deprecation warning. When positional parameters are used, the sniff will flag `$field` as missing, even though in reality (due to the secondary signature), the `$row` parameter is missing. This could possible be clarified by adding an "alternative" key to the array and using the value of that in the error message, but that's for later. Refs: * https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures#pg_fetch_result_pg_field_prtlen_and_pg_field_is_null * php/php-src 12728 * php/php-src@beaf1e8 * https://www.php.net/pg_fetch_result * https://www.php.net/pg_field_prtlen * https://www.php.net/pg_field_is_null Related to 1589
35 tasks
wimg
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OptionalToRequiredFunctionParameters: add missing false positive test case
PHP 8.4 | OptionalToRequiredFunctionParameters: account for deprecation of overloaded pg_*() signatures (RFC)
Note: when named parameters are used, the sniff will use the correct parameter name in the deprecation warning.
When positional parameters are used, the sniff will flag
$fieldas missing, even though in reality (due to the secondary signature), the$rowparameter is missing.This could possible be clarified by adding an "alternative" key to the array and using the value of that in the error message, but that's for later.
Refs:
Related to #1589