Skip to content

PHP 8.4 | RemovedFunctions: account for deprecation of intlcal_set() (RFC) #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wimg merged 1 commit into from
Feb 11, 2024
Merged

PHP 8.4 | RemovedFunctions: account for deprecation of intlcal_set() (RFC) #1674

wimg merged 1 commit into from
Feb 11, 2024

Conversation

@jrfnl
Copy link
Member

@jrfnl jrfnl commented Feb 3, 2024

  • Intl:
    . Calling intlcal_set() as well as calling IntlCalendar::set() with
    more than 2 arguments is deprecated. Use either IntlCalendar::setDate()
    or IntlCalendar::setDateTime() instead.

Refs:

Related to #1589

@jrfnl jrfnl added Type: enhancement PR: quick merge PR only contains relatively simple changes PR: ready for review labels Feb 3, 2024
@jrfnl jrfnl added this to the 10.0.0 milestone Feb 3, 2024
@jrfnl jrfnl requested a review from wimg February 3, 2024 06:43
@jrfnl jrfnl mentioned this pull request Feb 3, 2024
Open
35 tasks
@jrfnl
PHP 8.4 | RemovedFunctions: account for deprecation of intlcal_set() …
91db45a 
…(RFC)

> - Intl:
>   . Calling intlcal_set() as well as calling IntlCalendar::set() with
>     more than 2 arguments is deprecated. Use either IntlCalendar::setDate()
>     or IntlCalendar::setDateTime() instead.

Refs:
* https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures#intlcalendarset
* php/php-src 12728
* php/php-src@f4df37a
* https://www.php.net/manual/en/intlcalendar.set.php

Related to 1589
@jrfnl jrfnl force-pushed the php-8.4/removedfunctions-intcal_set-deprecation branch from a825c3c to 91db45a Compare February 3, 2024 06:54
@wimg wimg merged commit 1e5a305 into develop Feb 11, 2024
@wimg wimg deleted the php-8.4/removedfunctions-intcal_set-deprecation branch February 11, 2024 20:18
@github-actions github-actions bot removed PR: quick merge PR only contains relatively simple changes PR: ready for review labels Feb 11, 2024
@jrfnl jrfnl added the PHP: 8.4 label Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wimg wimg wimg approved these changes

Assignees

No one assigned

Labels

PHP: 8.4 Type: enhancement

Projects

None yet

Milestone

10.0.0-alpha1

Development

Successfully merging this pull request may close these issues.

3 participants

@jrfnl @wimg