RemovedFunctionParameters: add support for named parameters#1433
Merged
RemovedFunctionParameters: add support for named parameters#1433
Conversation
... to be in line with other sniffs and with the PassedParameters class.
1. Adjusted the way the correct parameter is retrieved to use the new PHPCSUtils 1.0.0-alpha4 `PassedParameters::getParameterFromStack()` method.
2. ~~Verified the parameter name used is in line with the name as per the PHP 8.0 release.~~
PHP itself renamed a lot of parameters in PHP 8.0. As named parameters did not exist before PHP 8.0, the parameter name as per PHP 8.0 (or above) is the only relevant name.
**_As most of these parameters have all been removed either before or in PHP 8.0, their name won't have undergone any changes (other than documentation-wise)._**
Name verification reference:
* most functions: https://3v4l.org/QLt1l
Includes adding/adjusting the unit tests to include tests using named parameters.
Member
Author
|
Note: the errorcode for anything with a changed parameter name will have changed. This needs a changelog entry! |
41 tasks
wimg
approved these changes
Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemovedFunctionParameters: change the offsets from 0-based to 1-based
... to be in line with other sniffs and with the PassedParameters class.
RemovedFunctionParameters: add support for named parameters
PassedParameters::getParameterFromStack()method.Verified the parameter name used is in line with the name as per the PHP 8.0 release.PHP itself renamed a lot of parameters in PHP 8.0. As named parameters did not exist before PHP 8.0, the parameter name as per PHP 8.0 (or above) is the only relevant name.
As most of these parameters have all been removed either before or in PHP 8.0, their name won't have undergone any changes (other than documentation-wise).
Name verification reference:
Includes adding/adjusting the unit tests to include tests using named parameters.
Related to #1239