Skip to content

New/RemovedHashAlgorithms: add support for named parameters#1394

Merged
wimg merged 1 commit intodevelopfrom
feature/1239-new-removed-hashalgos-support-named-params
Oct 31, 2022
Merged

New/RemovedHashAlgorithms: add support for named parameters#1394
wimg merged 1 commit intodevelopfrom
feature/1239-new-removed-hashalgos-support-named-params

Conversation

@jrfnl
Copy link
Copy Markdown
Member

@jrfnl jrfnl commented Oct 26, 2022

  1. Add support for function calls using named parameters by implementing the new PHPCSUtils 1.0.0-alpha4 PassedParameters::getParameterFromStack() method in the HashAlgorithmsTrait.
  2. Verified the parameter name used is in line with the name as per the PHP 8.0 release. PHP itself renamed a lot of parameters in PHP 8.0. As named parameters did not exist before PHP 8.0, the parameter name as per PHP 8.0 (or above) is the only relevant name.

Name verification reference:

Includes adding/adjusting the unit tests to include tests using named parameters.

Related to #1239

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants