Merged
Conversation
wimg
approved these changes
Jun 21, 2021
9d1e1bb to
2fac844
Compare
Member
Author
|
@wimg Wow, that was quick. While you reviewed, I found some more places it should be enabled in our script, so I updated the commit (twice more) 🙈 |
2fac844 to
e11170d
Compare
Turns out the default setting for `error_reporting` used by the SetupPHP action is `error_reporting=E_ALL & ~E_DEPRECATED & ~E_STRICT` and `display_errors` is set to `Off`. For the purposes of CI, I'd recommend running with `E_ALL` and `display_errors=On` to ensure **all** PHP notices are shown. In our script, we already enabled error_reporting, but the error display was not yet fixed. Sorted now.
e11170d to
0a585fb
Compare
Member
Author
|
Note: The lint failure on PHP 8.1 is unrelated to our code, but due to an issue in the PHP Parallel Lint repo. I've opened a PR there to fix that: php-parallel-lint/PHP-Parallel-Lint#64 |
wimg
approved these changes
Jun 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the default setting for
error_reportingused by the SetupPHP action iserror_reporting=E_ALL & ~E_DEPRECATED & ~E_STRICTanddisplay_errorsis set toOff.For the purposes of CI, I'd recommend running with
E_ALLanddisplay_errors=Onto ensure all PHP notices are shown.In our script, we already enabled error_reporting, but the error display was not yet fixed. Sorted now.