Composer: tweak the PHPUnit 4.x version used#1289
Merged
Conversation
The PHPUnit 4.x version used was based on a PHPUnit bug previously encountered in 511. It appears though that with changes which have been made to the test set up in the mean time, this bug no longer rears its ugly head, so we can now switch back to using the highest available PHPUnit 4.x version again.
aa92184 to
cc52526
Compare
wimg
approved these changes
Jun 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PHPUnit 4.x version used was based on a PHPUnit bug previously encountered in #511.
It appears though that with changes which have been made to the test set up in the mean time, this bug no longer rears its ugly head, so we can now switch back to using the highest available PHPUnit 4.x version again.
Note: this will allow for potentially using the PHPUnit Polyfills instead of working around PHPUnit cross-version incompatibilities ourselves.