Merged
Conversation
75cd46c to
74d5a08
Compare
As things were, coverage would only be run on pull requests and on `master`. Generally speaking, this is sufficient, but it does mean that the coverage over time is no longer properly tracked, which is a shame. The tweaks I'm making now should: * Still run the normal `test` and `coverage` jobs on pull requests and merges to `master. * For merges to `develop`, skip the `test` job, but do run the `coverage`, so it will be tracked again. * Skip the `quicktest` on `develop` as those are the same builds as for `coverage`, so no need to run those twice. * Also make sure that the coveralls-finish will actually run. Should after a build running just coverage already, but didn't.
74d5a08 to
a9436e1
Compare
wimg
approved these changes
May 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As things were, coverage would only be run on pull requests and on
master.Generally speaking, this is sufficient, but it does mean that the coverage over time is no longer properly tracked, which is a shame.
The tweaks I'm making now should:
testandcoveragejobs on pull requests and merges tomaster.develop, skip thetestjob, but do run thecoverage, so it will be tracked again.quicktestondevelopas those are the same builds as forcoverage, so no need to run those twice.