PHP 8.0 | RemovedNamespacedAssert: adjust for removal in PHP 8.0#1281
Merged
PHP 8.0 | RemovedNamespacedAssert: adjust for removal in PHP 8.0#1281
Conversation
> Declaring a function called `assert()` inside a namespace is no longer allowed, and issues `E_COMPILE_ERROR`. The `assert()` function is subject to special handling by the engine, which may lead to inconsistent behavior when defining a namespaced function with the same name. Ref: https://www.php.net/manual/en/migration80.incompatible.php This adjusts the existing sniff to take the change to fatal error in PHP 8.0 into account. Note: the error code of the sniff has been changed! This is a minor breaking change and should be annotated in the changelog.
380abbd to
6ef5d13
Compare
wimg
approved these changes
Apr 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://www.php.net/manual/en/migration80.incompatible.php
This adjusts the existing sniff to take the change to fatal error in PHP 8.0 into account.
Note: the error code of the sniff has been changed! This is a minor breaking change and should be annotated in the changelog.
Related to #809