Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPCSUtils
1.0.0-alpha4will add support for named parameters.Ref: PHPCSStandards/PHPCSUtils#235
To allow for this, any calls to
PassedParameters::getParameter()to retrieve a parameter in a function call need to pass the name of the target parameter.Within PHPCompatibility, this is the only sniff for which the tests would fail at the moment when used with PHPCSUtils alpha-4, so pre-eminently fixing this ahead of the release of PHPCSUtils 1.0.0-alpha4.
Adding unit tests for this change would break on alpha3 though, so I'm leaving those for a future PR once alpha4 has been released.