PHP 8.0: NewClasses: add yet more new classes #1246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> The OCI-Lob class is now called OCILob, and the OCI-Collection class is now > called OCICollection for name compliance enforced by PHP 8 arginfo > type annotation tooling. This commit: * Adds the new classes to the `NewClasses` sniff. * Updated the `alternative`s for various deprecated/removed functions in the `RemovedFunctions` sniff. Based on the commit, it looks like the _old_ classnames are removed without deprecation. Making a note of this in the `RemovedClasses` sniff, but not enabling the check as the places where we are searching for the name, do not allow for the old name in the first place - would have been a parse error. Also see: https://bugs.php.net/bug.php?id=79625 Refs: * https://github.com/php/php-src/blob/0a84fba0deb1c1b75770a436c4236dc56e6d0463/UPGRADING#L392-L394 * php/php-src@ff66e49
wimg
approved these changes
Dec 4, 2020
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.0: NewClasses: add new ReflectionUnionType class
Ref: https://wiki.php.net/rfc/union_types_v2#reflection
PHP 8.0 | OCI8: account for renamed classes
This commit:
NewClassessniff.alternatives for various deprecated/removed functions in theRemovedFunctionssniff.Based on the commit, it looks like the old classnames are removed without deprecation. Making a note of this in the
RemovedClassessniff, but not enabling the check as the places where we are searching for the name, do not allow for the old name in the first place - would have been a parse error. Also see: https://bugs.php.net/bug.php?id=79625Refs:
PHP 8.0: NewClasses: add new
UnhandledMatchErrorclass from the Match RFCRef: https://wiki.php.net/rfc/match_expression_v2