Conversation
…gisterThrowFalse` sniff > spl_autoload_register() will now always throw a TypeError on invalid > arguments, therefore the second argument $do_throw is ignored and a > notice will be emitted if it is set to false. Refs: * https://github.com/php/php-src/blob/c0172aa2bdb9ea223c8491bdb300995b93a857a0/UPGRADING#L393-L395 * php/php-src#5301 * php/php-src@2302b14 This sniff addresses that change. Includes unit tests.
wimg
reviewed
Aug 9, 2020
| * | ||
| * @since 10.0.0 | ||
| */ | ||
| class RemovedSplAutoloadRegisterThrowFalseSniff extends AbstractFunctionCallParameterSniff |
Member
There was a problem hiding this comment.
The classname makes it seem as if it throws false ?
Member
Author
There was a problem hiding this comment.
Got a suggestion for a better name which still aligns with the naming scheme of these type of ParameterValue sniffs ?
Member
There was a problem hiding this comment.
Tricky one... RemovedSplAutoloadRegisterThrowEqualsFalseSniff ?
wimg
approved these changes
Aug 18, 2020
| * | ||
| * @since 10.0.0 | ||
| */ | ||
| class RemovedSplAutoloadRegisterThrowFalseSniff extends AbstractFunctionCallParameterSniff |
Member
There was a problem hiding this comment.
Tricky one... RemovedSplAutoloadRegisterThrowEqualsFalseSniff ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs:
This sniff addresses that change.
Includes unit tests.
Related to #809