Conversation
…stency Oops... just saw this after PR 1150 was merged ... The feature is - at this time - only deprecated. Everywhere else, we throw a "warning" for deprecations and an "error" for removals/new features, so this should have been set to throw a "warning" for now. Also, as at some point in the future, the feature is expected to be removed, let's change the error code to `Deprecated` to allow for a second `Removed` error code once the feature is removed. Again, that is in line with how it's done in most places in the code base (though a cross-sniff consistency check at some point wouldn't be amiss). Having different error codes for Deprecated/Removed allows for ignoring deprecations, while still getting the errors when the feature actually gets removed.
0d203cb to
6321e80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oops... just saw this after PR #1150 was merged ...
The feature is - at this time - only deprecated. Everywhere else, we throw a "warning" for deprecations and an "error" for removals/new features, so this should have been set to throw a "warning" for now.
Also, as at some point in the future, the feature is expected to be removed, let's change the error code to
Deprecatedto allow for a secondRemovederror code once the feature is removed.Again, that is in line with how it's done in most places in the code base (though a cross-sniff consistency check at some point wouldn't be amiss).
Having different error codes for Deprecated/Removed allows for ignoring deprecations, while still getting the errors when the feature actually gets removed.