Skip to content

PHP 5.4: New PHPCompatibility.ParameterValues.NewNumberFormatMultibyteSeparators sniff#1139

Merged
wimg merged 1 commit intodevelopfrom
feature/new-newnumberformatmultibyteseparators-sniff
Jul 11, 2020
Merged

PHP 5.4: New PHPCompatibility.ParameterValues.NewNumberFormatMultibyteSeparators sniff#1139
wimg merged 1 commit intodevelopfrom
feature/new-newnumberformatmultibyteseparators-sniff

Conversation

@jrfnl
Copy link
Copy Markdown
Member

@jrfnl jrfnl commented Jun 29, 2020

From: https://www.php.net/manual/en/function.number-format.php#refsect1-function.number-format-changelog

This function now supports multiple bytes in dec_point and thousands_sep. Only the first byte of each separator was used in older versions.

This sniff addresses that change.

Includes unit tests.

…byteSeparators` sniff

From: https://www.php.net/manual/en/function.number-format.php#refsect1-function.number-format-changelog

> This function now supports multiple bytes in `dec_point` and `thousands_sep`. Only the first byte of each separator was used in older versions.

This sniff addresses that change.

Includes unit tests.
@wimg wimg merged commit 03fc45e into develop Jul 11, 2020
@wimg wimg deleted the feature/new-newnumberformatmultibyteseparators-sniff branch July 11, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants