Thank you for your contribution ! Great job !

This sniff is not quite correct.

PHP4-style constructors are only deprecated if there is no PHP5-style constructor. Therefore the following code is fine in PHP 7 and the sniff should not emit an error:

class foo {

    function __construct() {
        echo 'I am the constructor';
    }

    function foo() {
        echo 'I am NOT the constructor';
    }

}

Reference: http://php.net/manual/en/migration70.deprecated.php

Thanks for mentioning it. We'll get it fixed ;-)

Cool.

When adding the unit tests, as well as the example above, I would add a test to cover those two functions in the opposite order (as the implementation should not care about the order of class methods).

It would also be good to have a test that tests the case-insensitivity of the constructor name, e.g.

class foo {

    function FOO() {
        echo 'I am the constructor';
    }

}

I'm not sure if this would currently trigger a sniff error (as it should) or not.