Conversation
PHPCompatibility.ParameterValues.RemovedAssertStringAssertion sniffPHPCompatibility.ParameterValues.RemovedAssertStringAssertion sniff
…ssertion` sniff > Usage of a string as the assertion became deprecated. It now emits an E_DEPRECATED > notice when both assert.active and zend.assertions are set to 1. Refs: * https://wiki.php.net/rfc/deprecations_php_7_2#assert_with_string_argument * https://www.php.net/manual/en/function.assert.php#refsect1-function.assert-changelog This sniff addresses that change. Includes unit tests. Partially addressed 908
398ea25 to
e572a56
Compare
…letely removed
> `assert()` will no longer evaluate string arguments, instead they will be
> treated like any other argument. `assert($a == $b)` should be used instead of
`assert('$a == $b')`.
Ref:
* https://github.com/php/php-src/blob/69888c3ff1f2301ead8e37b23ff8481d475e29d2/UPGRADING#L350-L354
Includes adjusted unit tests.
42ff32a to
782a301
Compare
wimg
approved these changes
May 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs:
This sniff addresses that change.
Includes unit tests.
Partially addresses #908
PHP 8.0: RemovedAssertStringAssertion: account for support being completely removed
Ref:
Includes adjusted unit tests.