Update Travis file and fix build by Potherca · Pull Request #86 · PHPCSStandards/composer-installer

Potherca · 2019-09-11T18:39:47Z

Proposed Changes

Currently the Travis build is breaking because the URL used by the security-checker no longer exists.
This MR updates that URL to the new home in order to fix the build.

It also adds a preview for PHP 7.4 and makes minor changes to improve the build step.

Potherca · 2019-09-11T18:41:45Z

@mjrider, can you review (and optionally merge) this, if @frenck is unavailable?

Potherca · 2019-09-11T18:56:49Z

Looks like this fixes part of the issue... PHP5.4 and PHP5.5 need Trusty to build.

However, changing the matrix to this:

matrix:
  include:
    - php: 7.2
      env: SNIFF=1
    - php: 5.5
      # As the latest Debian not supporting PHP 5.5 anymore, we need to force using 'trusty'.
      dist: trusty
    - php: 5.4
      # As the latest Debian not supporting PHP 5.4 anymore, we need to force using 'trusty'.
      dist: trusty
    - php: 5.3
      # As the latest Debian not supporting PHP 5.3 anymore, we need to force using 'precise'.
      dist: precise

did not yield the expected result (i.e. Trusty being used...)

jrfnl

Some suggestions:

As this repo does not have a committed composer.lock file, instead of using the sensiolabs/security-checker as you are now, you could replace that Composer dependency with roave/security-advisories.
That way, the check will still be executed, but will be done during the composer install step and it would remove your dependency on an outside URL during your builds.
Adding dist: trusty at the top of the script (and removing sudo: false which is no longer supported) should fix the build failures for PHP 5.4 and 5.5.

jrfnl · 2019-09-11T19:51:35Z

Oh and as you're making changes to the Travis script now anyway, why not add a build against "7.4snapshot", possibly with an allow_failures for it too ?

- Only run secondary checks once (on latest PHP version)

Potherca · 2019-09-15T17:22:09Z

@mjrider I'm all done. Can you please review/approve so these changes can be merged to master?

They are needed before I can update the other open MRs.

.travis.yml

Special consideration for the php 5.3 build, its 🤪

mjrider

Update security-checker to new URL to fix build.

49e4850

Potherca added the Type: builds / deploys / releases label Sep 11, 2019

Potherca added this to the Release v0.5.1 (Next Minor Release) milestone Sep 11, 2019

Potherca force-pushed the ci-build/update-security-checker branch from 2e65b1d to 49e4850 Compare September 11, 2019 18:54

Potherca mentioned this pull request Sep 11, 2019

Respect PHP version used by Composer and provide better feedback on failure #80

Merged

Potherca requested a review from mjrider September 11, 2019 19:28

Potherca mentioned this pull request Sep 11, 2019

Add support for a string phpcodesniffer-search-depth config value set via composer config #85

Merged

jrfnl reviewed Sep 11, 2019

View reviewed changes

mjrider self-assigned this Sep 12, 2019

Potherca force-pushed the ci-build/update-security-checker branch from f89fa5a to f55f292 Compare September 15, 2019 15:31

Fix debian distribution for older PHP versions.

38648a8

Potherca force-pushed the ci-build/update-security-checker branch 2 times, most recently from 4e00d60 to bfc7155 Compare September 15, 2019 16:57

Potherca added 2 commits September 15, 2019 19:04

Cleanup Travis CI file

052dffd

- Only run secondary checks once (on latest PHP version)

Add 7.4snapshot to travis build matrix.

12118a3

Potherca force-pushed the ci-build/update-security-checker branch from bfc7155 to 12118a3 Compare September 15, 2019 17:05

Potherca changed the title ~~Update security-checker to new URL to fix build.~~ Update Travis file and fix build Sep 15, 2019