Merged
Conversation
This plugin already has PHP_CodeSniffer as a dependency, but the project itself should also be checked against code standards. While PSR-2 is already included, it would be useful to also check that the code supports down to the PHP 5.3 version specified in the Travis CI config file.
c2dae7e to
53290da
Compare
Member
|
Let me begin by stating that I am not opposed to this. It makes sense and if there are no major trade-offs I don't see any reason why not to merge this. I don't have time to discuss this with @frenck until after the weekend, so we'll get back to you in the coming week. |
Potherca
approved these changes
Sep 16, 2017
frenck
approved these changes
Sep 16, 2017
Contributor
|
Approved, will update VersionEye to allow merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This plugin already has PHP_CodeSniffer as a dependency, but the project itself should also be checked against code standards.
While PSR-2 is already included, it would be useful to also check that the code supports down to the PHP 5.3 version specified in the Travis CI config file.
The inclusion of the
scriptis so that those developing this repo can easily register the PHPCompatibility standard.This is a prelude to #39.