Conversation
Contributor
Author
|
Travis tests fails, enabled by @Potherca, but not configured it yet. |
Potherca
approved these changes
May 9, 2017
| $changes = false; | ||
| $codingStandardPackages = $this->getPHPCodingStandardPackages(); | ||
|
|
||
| $searchPaths = [getcwd()]; |
Member
There was a problem hiding this comment.
For completeness sake: although usually using getcwd (and consorts) is discouraged, this is the "Composer Way" of doing things.
Contributor
Author
|
Just thought of an edge case that might cause troubles with this solution:
This might cause the installation of the local coding standard into the global scope. Will check on this tomorrow. |
Contributor
Author
|
Checked my above concerns and concluded this won't be an issue since the Composer GlobalCommand will change the working directory before actually running Composer (again). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This change adds support for having PHP_CodeSniffer standards in the root package.
Related Issues
Implements: #20 Check the root package for sniffs to install