Conversation
This now reverts the second code modernization from 234 as well. Annoying, but so be it. I've also now added warnings in both places which were modernized and for which the modernizations had to be reverted to hopefully prevent this happening again. Fixes 247
GaryJones
approved these changes
Jul 9, 2025
Contributor
GaryJones
left a comment
There was a problem hiding this comment.
✅ Tested by adding "dealerdirect/phpcodesniffer-composer-installer": "dev-feature/247-fix-fatal-revert-second-codemodernization as 1.99", to my global composer.json, and I was able to install the WP-CLI package I was trying to in #247.
Potherca
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This now reverts the second code modernization from #234 as well. Annoying, but so be it.
I've also now added warnings in both places which were modernized and for which the modernizations had to be reverted to hopefully prevent this happening again.
Related Issues
Fixes #247
Suggested changelog entry
Fixed