Added instanceof check to prevent root package from being installed#21
Merged
Potherca merged 3 commits intoPHPCSStandards:masterfrom Mar 16, 2017
codenamephp:master
Merged
Added instanceof check to prevent root package from being installed#21Potherca merged 3 commits intoPHPCSStandards:masterfrom codenamephp:master
Potherca merged 3 commits intoPHPCSStandards:masterfrom
codenamephp:master
Conversation
Ignoring root package when installing so the plugin will work again when installed into a code sniff package
Documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The root package needs a different install path (since it's not really installed, it's already there) so right now the install fails. The instance of check prevents the package from being installed if the package has the RootPackageInterface.
Related Issues
Fix for #19
I had some spare minutes and wanted to continue my sniff so I just fixed it online on Github so I won't mess up the formatting.