Skip to content

Rename references to master branch#199

Closed
jrfnl wants to merge 1 commit intomainfrom
feature/160-update-references-to-default-branch
Closed

Rename references to master branch#199
jrfnl wants to merge 1 commit intomainfrom
feature/160-update-references-to-default-branch

Conversation

@jrfnl
Copy link
Copy Markdown
Member

@jrfnl jrfnl commented Jan 2, 2023

Proposed Changes

This PR is to be merged in conjunction with the branch rename to main as discussed in #160

Related Issues

Fixes #160

@jrfnl
Rename references to master branch
02f83b9 
This PR is to be merged in conjunction with the branch rename to `main` as discussed in 160

Fixes 160
@jrfnl jrfnl added this to the Release v1.0.0 milestone Jan 2, 2023
@jrfnl jrfnl requested a review from a team January 2, 2023 21:53
@Potherca Potherca mentioned this pull request Jan 5, 2023
Closed
Potherca
Potherca approved these changes Jan 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Potherca Potherca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the code, I didn't find other instances that the ones changed here.

The only other reference is https://github.com/PHPCSStandards/composer-installer/blob/master/tests/PHPCSVersions.php#L23 but if I understand correctly that is the branch on PHPCS not this project.

@jrfnl
Copy link
Copy Markdown
Member Author

jrfnl commented Jan 5, 2023

I've checked the code, I didn't find other instances that the ones changed here.

The only other reference is https://github.com/PHPCSStandards/composer-installer/blob/master/tests/PHPCSVersions.php#L23 but if I understand correctly that is the branch on PHPCS not this project.

100% correct. That's the PHPCS branch, not a reference to a branch in this project. Only thing we could do there, would maybe be to update line 19 to make it crystal clear that is a PHPCS branch reference:

composer-installer/tests/PHPCSVersions.php

Line 19 in fcae465

* Composer name for the development branch.

@Potherca Potherca changed the base branch from master to main January 5, 2023 11:19
@Potherca Potherca marked this pull request as ready for review January 5, 2023 11:19
@Potherca Potherca deleted the branch main January 5, 2023 11:25
@Potherca Potherca closed this Jan 5, 2023
@Potherca Potherca mentioned this pull request Jan 5, 2023
Merged
@Potherca Potherca deleted the feature/160-update-references-to-default-branch branch January 5, 2023 11:28
@Potherca
Copy link
Copy Markdown
Member

Potherca commented Jan 5, 2023

I have renamed branch master to main. These changes have been merged into main via #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Potherca Potherca Potherca approved these changes

Assignees

No one assigned

Labels

Type: builds / deploys / releases Type: documentation

Milestone

Release v1.0.0

Development

Successfully merging this pull request may close these issues.

Open discussion: rename the default branch ?

2 participants

@jrfnl @Potherca