Conversation
As discussed in 181. Fixes 181
…d all uses This method was put in place in PR 153 (commit d4f64b8) as a work-around for the problematic PHP 5.5 / Composer v1 on Windows build. As we won't be running the tests against that particular combination anymore, I propose we remove all these work-arounds from the test suite. This effectively reverts the following commits (and a little more): * f0251b8. * ccd127f. * d4f64b8.
Member
Author
|
FYI: I've removed the build I'm now excluding from the "required statuses" in the branch protection rules. |
Potherca
approved these changes
Jun 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
GH Actions: stop running tests against PHP 5.5/Composer 1.x on Windows
As discussed in #181.
Fixes #181
Tests: remove the
TestCase::willPluginOutputShow()helper method and all usesThis method was put in place in PR #153 (commit d4f64b8) as a work-around for the problematic PHP 5.5 / Composer v1 on Windows build.
As we won't be running the tests against that particular combination anymore, I propose we remove all these work-arounds from the test suite.
This effectively reverts the following commits (and a little more):
Related Issues
#181