Merged
Conversation
Potherca
reviewed
May 25, 2022
Potherca
previously approved these changes
May 25, 2022
a6d58ea to
423960e
Compare
Potherca
previously approved these changes
May 26, 2022
This new test class tests that the plugin always registers the installed_paths in the same order. I have confirmed that the tests would fail on various CI builds without the fix from 126. Notes: * This test is about Composer and the plugin, so does not need to be tested against multiple PHPCS versions. This test class covers the following bug previously reported: * Dealerdirect/phpcodesniffer-composer-installer issue 125 * Dealerdirect/phpcodesniffer-composer-installer PR 126
423960e to
830516b
Compare
Member
Author
|
Rebased without changes after the merge of #180 to get a clean and passing build. Will merge after the build passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This new test class tests that the plugin always registers the
installed_pathsin the same order.I have confirmed that the tests would fail on various CI builds without the fix from #126.
Notes:
This test class covers the following bug previously reported:
installed_pathsinconsistent between runs #125Related Issues
Related to #92