Tests: add new PlayNiceWithScriptsTest#169
Merged
Conversation
This new test class tests that the plugin does not block other post install/update scripts from running. I have confirmed that this test as-is would fail in combination with the `0.6.0` and `0.6.1` versions of the plugin and would pass with `0.5.0`, `0.6.2` and current. For confirmation see this build against `0.6.0`: https://github.com/Dealerdirect/phpcodesniffer-composer-installer/actions/runs/1787983161 (only run against Composer 1 as `0.6.0` was not compatible with Composer 2 yet). Notes: * This test is about Composer and the plugin, so does not need to be tested against multiple PHPCS versions. * The behaviour also shouldn't differ between a global vs local Composer install, so only testing one type. This test class covers the following bug previously reported: * Dealerdirect/phpcodesniffer-composer-installer PR 105
Potherca
approved these changes
Mar 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This new test class tests that the plugin does not block other post install/update scripts from running.
I have confirmed that this test as-is would fail in combination with the
0.6.0and0.6.1versions of the plugin and would pass with0.5.0,0.6.2and current.For confirmation see this build against
0.6.0: https://github.com/Dealerdirect/phpcodesniffer-composer-installer/actions/runs/1787983161 (only run against Composer 1 as0.6.0was not compatible with Composer 2 yet).Notes:
Related Issues
This test class covers the following bug previously reported:
Related to #92