Tests: add new PreexistingPHPCSConfigTest#166
Merged
Conversation
This new test class tests that the plugin handles a pre-existing PHPCS configuration file correctly. These tests verify: - That the plugin will add the `installed_paths` setting correctly. - That the plugin does not remove or alter existing configurations, except for the `installed_paths`. Notes: * As PHPCS behaves the same whether installed locally or globally, it is unnecessary to run the tests in both type of environments. * As the output of the `config-show` command in PHPCS has changed across PHPCS version, it is necessary to test against multiple PHPCS versions. This test class covers the following bug previously reported: * Dealerdirect/phpcodesniffer-composer-installer PR 98
Potherca
approved these changes
Mar 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This new test class tests that the plugin handles a pre-existing PHPCS configuration file correctly.
These tests verify:
installed_pathssetting correctly.installed_paths.Notes:
config-showcommand in PHPCS has changed across PHPCS version, it is necessary to test against multiple PHPCS versions.Related Issues
This test class covers the following bug previously reported:
loadInstalledPaths()very very broken since PHPCS 3.1.0 #98Related to #92