Conversation
While looking into the race condition described in 125, I noticed a potentially related issue. As per the documentation of [realpath()](https://www.php.net/manual/en/function.realpath.php#refsect1-function.realpath-returnvalues): > realpath() returns FALSE on failure, e.g. if the file does not exist. In the rare case that `realpath()` _would_ return `false` within this plugin, `false` would subsequently be passed on to `is_dir()` and `is_readable()` which both expect a string path. This tiny change make the condition fail earlier by checking the return value of `realpath()`.
Potherca
approved these changes
Dec 8, 2020
Member
Author
|
@Potherca Just checking: where there any changed you wanted ? Or did you assign this to me to self-merge ? |
Member
|
No changes needed. I just didn't feel like waiting around for Travis to complete but also didn't want to use my admin right to merge again. I assigned you in case I forgot to come back to this 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
While looking into the (non-)race condition described in #125, I noticed a potentially related issue.
As per the documentation of realpath():
In the rare case that
realpath()would returnfalsewithin this plugin,falsewould subsequently be passed on tois_dir()andis_readable()which both expect a string path.This tiny change makes the condition fail earlier by checking the return value of
realpath().