Test with PHPCS 4.x and allow installation when using PHPCS 4.x#107
Merged
Test with PHPCS 4.x and allow installation when using PHPCS 4.x#107
Conversation
Development for PHPCS 4.x has started in a new `4.0` branch.
This PR is two-fold:
1. On the one hand, it adds testing against PHPCS 4.x to the Travis matrix as an early warning system in case any cross-version compatibility fixes would be needed for the plugin itself.
The build against `4.x-dev` has been added to `allow_failures` for now.
Note: as PHPCompatibility currently doesn't allow for PHPCS 4.x (yet), I'm aliasing the install to `3.9.99` for testing purposes in the Travis build only.
2. On the other hand, it allows installation in combination with PHPCS 4.x, which will in turn allow external standards which `require` this plugin, to start testing their standard against the PHPCS 4.x-dev branch.
As it was now, external standards would get the plugin at version `0.4.4` as that's the last version with a PHPCS `*` constraint.
Potherca
approved these changes
Apr 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Development for PHPCS 4.x has started in a new
4.0branch.This PR is two-fold:
The build against
4.x-devhas been added toallow_failuresfor now.Note: as PHPCompatibility currently doesn't allow for PHPCS 4.x (yet), I'm aliasing the install to
3.9.99for testing purposes in the Travis build only.requirethis plugin, to start testing their standard against the PHPCS 4.x-dev branch.As it was now, external standards would get the plugin at version
0.4.4as that's the last version with a PHPCS*constraint.Related Issues