Merged
Conversation
As it was, the plugin when used by external standards, would block them from being tested on PHP 8. As all the dependencies in the `require` section allow for PHP 8, there is no reason not to allow it. The only dependencies currently in use which do not allow for PHP 8 yet are in the `require-dev` section. See the below output. This includes updating the Travis script to only do a full (`dev`) install when not on `nightly` and as PHPCompatibility is in the `require-dev` section, we need to require explicitly for `nightly` to make sure the integration test can run. ```bash # composer prohibits php:8 composer/composer 1.9.3 requires php (^5.3.2 || ^7.0) composer/semver 1.5.1 requires php (^5.3.2 || ^7.0) seld/jsonlint 1.7.2 requires php (^5.3 || ^7.0) symfony/console v4.4.4 requires php (^7.1.3) symfony/filesystem v4.4.4 requires php (^7.1.3) symfony/finder v4.4.4 requires php (^7.1.3) symfony/process v4.4.4 requires php (^7.1.3) symfony/service-contracts v2.0.1 requires php (^7.2.5) ```
4dba9a7 to
db97d73
Compare
Potherca
approved these changes
Feb 16, 2020
Member
|
Nice work! Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
As it was, the plugin when used by external standards, would block them from being tested on PHP 8.
As all the dependencies in the
requiresection allow for PHP 8, there is no reason not to allow it.The only dependencies currently in use which do not allow for PHP 8 yet are in the
require-devsection. See the below output.This includes updating the Travis script to:
dev) install when not onnightly.nightlyas otherwise thedevrequirements would still block installation.require-devsection, we need to require it explicitly fornightlyto make sure the integration test can run.As the Travis build on PHP
nightlypasses, I'm semi-confident that all should be good, though confidence will grow once we add more unit/integration tests.