Conversation
…owing naming conventions" This reverts commit 71b4524. Includes further enhancements to strictly apply the naming conventions by: 1. Making sure that the FQN contains a `Sniffs` or `Tests` sub-namespace in the correct position. 2. Making sure that the category is not called `Sniffs`. 3. Making sure that a class ends on `Sniff` or `UnitTest`, and that that is a suffix, not the sole name of the class. Includes updating the tests. Related to 689 Related to 6
The [About Standards for PHP_CodeSniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer/wiki/About-Standards-for-PHP_CodeSniffer) wiki page outlines exactly what the naming conventions are. This PR changes the previously added Ruleset deprecation notice to an error and starts rejecting sniffs which do not comply with the naming conventions. Includes updated tests. Closes 689 Related to 6
3fa4bf6 to
c2636f5
Compare
Member
Author
|
Rebased to remove an outdated comment from one of the commit messages. No changes to the code. |
rodrigoprimo
approved these changes
Apr 14, 2025
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revert "Common::getSniffCode(): be more lenient about sniffs not following naming conventions"
This reverts commit 71b4524.
Includes further enhancements to strictly apply the naming conventions by:
SniffsorTestssub-namespace in the correct position.Sniffs.SnifforUnitTest, and that that is a suffix, not the sole name of the class.Includes updating the tests.
Related to #689
Related to #6
Ruleset: remove support for sniffs not following the naming conventions
The About Standards for PHP_CodeSniffer wiki page outlines exactly what the naming conventions are.
This PR changes the previously added Ruleset deprecation notice to an error and starts rejecting sniffs which do not comply with the naming conventions.
Includes updated tests.
Closes #689
Related to #6
Suggested changelog entry
Removed: