Universal/DuplicateArrayKey: add extra tests #363
Merged
Conversation
Numeric strings which do not comply with the rules for PHP 7.4 numeric literals with underscores should not be regarded as numeric array indexes. This bug was fixed in PHPCSUtils 1.1.0. This commit adds some tests to safeguard the fix in the sniff for which this problem was originally reported. See PHPCSStandards/PHPCSUtils 619
Related to PHPCSStandards/PHPCSUtils 668
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Universal/DuplicateArrayKey: add extra tests
Numeric strings which do not comply with the rules for PHP 7.4 numeric literals with underscores should not be regarded as numeric array indexes.
This bug was fixed in PHPCSUtils 1.1.0.
This commit adds some tests to safeguard the fix in the sniff for which this problem was originally reported.
See PHPCSStandards/PHPCSUtils#619
Universal/DuplicateArrayKey: add tests with FQN true/false
Related to PHPCSStandards/PHPCSUtils#668