✨ New Universal.PHP.NoFQNTrueFalseNull sniff#327
Merged
Conversation
Member
Author
|
@rodrigoprimo Fancy reviewing this PR ? |
... to forbid using `true`, `false` and `null` as fully qualified constants. Includes fixer. Includes unit tests. Includes documentation. Note: yes, there is a related tokenizer issue in PHPCS where these tokens are not tokenized the same PHP cross-version, however, the tokenization will change in PHPCS 4.0 as well, so there isn't much point addressing that now as it would just make things even more complicated for sniffs come PHPCS 4.0. And yes, this does mean that this sniff will need adjusting for PHPCS 4.0.
871abc6 to
53fa0b6
Compare
Member
Author
|
Rebased without changes to allow for new CI check. |
rodrigoprimo
approved these changes
Mar 20, 2025
rodrigoprimo
left a comment
There was a problem hiding this comment.
Looks good to me!
(sorry for the delay to review this PR)
Member
Author
|
Thanks for reviewing @rodrigoprimo ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... to forbid using
true,falseandnullas fully qualified constants.Includes fixer.
Includes unit tests.
Includes documentation.
Note: yes, there is a related tokenizer issue in PHPCS where these tokens are not tokenized the same PHP cross-version, however, the tokenization will change in PHPCS 4.0 as well, so there isn't much point addressing that now as it would just make things even more complicated for sniffs come PHPCS 4.0.
And yes, this does mean that this sniff will need adjusting for PHPCS 4.0.